Ahmed Yasser
Ahmed Yasser
**Old:** Float 64 `@benchmark SpecialFunctions.erf(data) setup=(data=6*rand(Float64)-3) samples=1000000` > BenchmarkTools.Trial: 217729 samples with 1000 evaluations per sample. > Range (min … max): 6.300 ns … 283.700 ns ┊ GC (min …...
Float32 implementation available, but not faster than Float64 version due to a exp() call. Float64 version still faster than old Float32.
need to clean up polynomial evaluations. code also could use more organization
Remaining: erfc Float64 and Float32 implementations, and the erf Float32 implementation
There aren't any tests for erfc. Is that expected?
Any other changes needed?
Yes, you're correct. The old implementation was not efficient so I redid it. # Old **Float64** `@benchmark erf(data) setup=(data=6*rand(Float64)-3) samples=1000000` > BenchmarkTools.Trial: 217081 samples with 1000 evaluations per sample. Range...
Anything left for me to do?
It's been a pleasure 😄