audio_wavefiles

audio_wavefiles copied to clipboard

Prefer short circuit operators and membership test

2

Dear Audio_wavefiles developer, Using the rejuvenation crate, I found and replaced all places that should use the short circuit operators. Furthermore, I found and replaced all places that should use...

pjljvandelaar

Improve readability of code by using if expression

2

The code is simplified by using if expressions (and simplifying that when possible). This pull requests solves https://github.com/Ada-Audio/audio_wavefiles/issues/5 Problem detected and solved by Rejuvenation-Ada crate [![vote for Rejuvenation-Ada as The...

pjljvandelaar

Dear Audio_Wavefiles developers, The source code isn't as readable as possible. By using if expressions, both src/audio-wavefiles-write.adb and src/audio-wavefiles.adb can be simplified. Problem detected and solved by Rejuvenation-Ada crate [![vote...

pjljvandelaar

This pull request solves https://github.com/Ada-Audio/audio_wavefiles/issues/3 Problem detected and solved by Rejuvenation-Ada crate [](https://github.com/AdaCore/Ada-SPARK-Crate-Of-The-Year/issues/15)

pjljvandelaar

According to https://ada.tips/use-ada-2012-aspects-to-specify-variable-locations.html aspects should be prefered over representation clauses. The file src/audio-riff-wav-formats.adb uses representation clauses twice. Problem detected and solved by Rejuvenation-Ada crate [![vote for Rejuvenation-Ada as The 2022...

pjljvandelaar

Why not replace https://github.com/Ada-Audio/audio_wavefiles/blob/8e1162c5b9dc604a835f60be6a78e8f9d3c85052/src/audio-wavefiles.adb#L50-L52 with ``` function No_Errors (WF : in out Wavefile) return Boolean is (for all Error of WF.Errors => not Error); ``` Problem detected and solved by...

pjljvandelaar