Andrey Balioha comments

Repositories
Issues
Comments

Results 3 comments of


                                            Andrey Balioha

wrong Double to UInt256 conversion

The problem goes deeper to `Lsh(in UInt256 x, int n, out UInt256 res)` when in and out params are the same ``` var u = new UInt256(1); UInt256.Lsh(in u, 1,...

fix: UInt256: Divide, Lsh, Rsh, Exp, ExpMod, SubtractMod; Int256: Multiply - when in and out params are referenced to the same struct

Added some tests - found much more bugs. I checked Nethermind - it is not affected

fix: UInt256: Divide, Lsh, Rsh, Exp, ExpMod, SubtractMod; Int256: Multiply - when in and out params are referenced to the same struct

last commit failed because this code gives different output in different OS ``` double x = ulong.MaxValue; Console.WriteLine(x); Console.WriteLine((ulong)x); ``` On Linux 22.04 (7.0.305) this will result in: ``` 1.8446744073709552E+19...