Aaron Feickert
Aaron Feickert
Might it be useful to keep the attributes as a helpful indication for implementers and silence the warnings, as in #121?
Note the correctness and consistency of the sender-encrypted data (like that of existing recipient-encrypted data) cannot be checked by the network. This means that if a user does not wish...
Interestingly, this could in certain cases replace payment proofs. Payment proofs reveal coin information (value, memo, and recipient address) to the verifier, but also assert that the prover had spend...
It's likely a better idea to create a `ClaimProof` class that handles the (de)serialization.
Added basic tests.
Fair enough. I would certainly recommend more documentation about the nature of the optimization barriers used, so users can make a more informed decision based on use cases.
Marking as draft for now, since #419 would add `subtle` support via an optional feature that would presumably be used here.
The optimization barrier in `subtle` used to be inline assembly, but it was changed a few years back (and has seen some iteration). I've seen discussion about returning to that...
Anyway, I'm happy to close this if the performance hit isn't worth the library change and Miri cleanup.
Is there a particular reason why the current Miri workaround doesn't just use variable-time equality, if it's not intended for use outside of testing (and not used for benchmarks)? Having...