Eric R. Scott
Eric R. Scott
I actually think the appearances of `stringsAsFactors` in `04-data-structures-part1.Rmd` are "fine". Since the new default for `stringsAsFactors` is `FALSE`, it does need to be set to `TRUE` if you want...
Some additional things in #1681
tests are still skipped in test.read.settings.R
I think this is the line that needs changing: https://github.com/PecanProject/pecan/blob/cd3e4c2dc1739b4165574dd1200f73886d80af9a/base/utils/R/convert.input.R#L100 `exists()` looks for an R object in the global environment. Looks like it could probably be replaced with something like...
With 5 PFTs specified I get 4 warnings: ``` 2022-07-18 22:22:38 WARN [PEcAn.DB::db.close] : Connection might have been closed already. 2022-07-18 22:22:38 WARN [PEcAn.DB::db.close] : Connection might have been closed...
Not only is there code commented out in met2CF.csv.R, but there's not actually any valid `testthat` tests. Un-stale-ing
Ok, so I think the problem on my end is an incorrect ``, but I still think this should fail fast if the job ID is `NULL`
So to clarify, here's what I think should happen if the job ID is `NULL` for any reason (e.g. an incorrect pattern in `): 1) print a message like "Job...
A suggestion: make it more clear from function names which functions return objects and which are called for their side-effects. E.g. `get.trait.data()` and `do_conversions()` return a modified settings object but...
NOTE: this adds a 16mb file for testing (replacing a ~5mb one) I don't think I can get this file any smaller (this is the size even when ED2 simulation...