Arran Schlosberg
Arran Schlosberg
`backends.SimulatedBackend` has an internal method `callContract()` that is common to each of `CallContract()`, `PendingCallContract()` and `EstimateGas()`. In cloning the EVM to run the calls, it fails to to copy any...
https://github.com/Anish-Agnihotri/MultiRaffle/blob/55c4c4af14ab06f795b564ed42f569ea420e1d4f/src/MultiRaffle.sol#L223 What do you think about `_safeMint(msg.sender, ticket[i])` instead? Currently, if there's any value in a low `tokenId` then there's an incentive for gas wars / people gaming the system,...
This is a great initiative, thanks for starting it. Your Fisher–Yates implementation biases selection of early entrants by use of modulus ([Wiki explanation](https://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle#Modulo_bias)). https://github.com/Anish-Agnihotri/MultiRaffle/blob/55c4c4af14ab06f795b564ed42f569ea420e1d4f/src/MultiRaffle.sol#L177 I suspect that reuse of the...
### What is the current behavior? Only string-literal filters can be passed to `assert_json_matches`, but `jq()` supports using files. ### Describe the feature Change the signature to: ```Starlark assert_json_matches(name, file1,...
This was originally [PR #7781 of the EIPs repo](https://github.com/ethereum/EIPs/pull/7781), which was closed because of the migration to this repo. The ERC number 7526 was assigned by @abcoathup in that PR.
## Why this should be merged ## How this works Rename `vm.RunPrecompiledContract()` to `vm.geth_RunPrecompiledContract()` and change all calls to the former to `RunStatefulPrecompiledContract()`, which should be implemented independently. ## How...
## Why this should be merged ## How this works ## How this was tested ## How is this documented
## Why this should be merged From `x/gethclone/README.md`: > This is an experimental module for tracking upstream `go-ethereum` changes. The approach of `git merge`ing the upstream branch into `subnet-evm` is...
build(tests): require `//go:build test` tag if importing test packages outside of `_test.go` files
## Why this should be merged Including test-only code in non-test files risks leaking said functionality into production. ## How this works A new linter finds all `*.go` files that...
#3173 introduces a linter to catch leaking of test-only code into production. Most instances of `testing` imports can be excluded with build tags. This is a tracking issue to document...