Alexander Mikhailov comments

Results 6 comments of


                                            Alexander Mikhailov

AlreadyHave function can fail for txs already in blocks

There are many orphans, so I believe there are many different reasons for them. I will try to list here what I find: 1) Locktime issue If a node lags...

AlreadyHave function can fail for txs already in blocks

I think I found the main source of orphans: Orphans I was observing were not truly orphans. They were _already_ included in a block. And this block was _already_ processed...

Replace command name with byte code in p2p message

I would add that those human-readable command names are too short sometimes. For example `grapheneblock` is 13 characters and I had to improvise...

Write functional test that checks p2p messages serialization/deserialization

> Should we have p2p__schema.py separately or you plan to list all p2p messages in one test and send them through the proposed setup? Initial idea was to list them...

Write functional test that checks p2p messages serialization/deserialization

@cmihai yeah, the thing you pointed was actually created by me. But It unfortunately skips serialization/deserialization completely - it relays the whole received buffer.

Disable diffusion for outbound connections

I was not sure which label/issue type to choose. Feel free to change to appropriate type