Antoine Languillaume

Results 18 comments of Antoine Languillaume

golem::document_and_reload is not using get_golem_config to figure out where the golem configuration is

Hi @harell, Thanks for reporting this. TLDR: Currently you cannot change the location of `inst/golem-config.yml` despite what the comment in `get_golem_config()` says. Apologies for that. We will try to make...

golem::document_and_reload is not using get_golem_config to figure out where the golem configuration is

@ColinFay I started working on a fix in branch `fix-change-config-yml-loc`. See thread on our Slack.

wrong default file path in `run_dev()` documentation, file path hard coded

Hi @Teebusch, Thanks a lot for reporting this and fixing our mistakes. Go ahead with a PR !

wrong default file path in `run_dev()` documentation, file path hard coded

Make sure to start from the `dev` branch, though, as specified in CONTRIBUTING.md https://github.com/ThinkR-open/golem/blob/dev/R/run_dev.R

allow golem::fill_desc to use `person` vector

This is already the case in fusen. https://github.com/ThinkR-open/fusen/blob/main/R/fill_description.R

Edition-related functions should accept only existing editions (2 and 3)

I would be glad to work on a PR.

Improve `convert_chunk_header()`

What about making sure option are converted from `echo = FALSE` to `#| echo: false` ? Currently : `echo = FALSE` will yield `#| echo = FALSE` My humble expectation...

Improve `convert_chunk_header()`

My bad `knitr::convert_chunk_header("foo.Rmd", output = "foo.qmd", type = "yaml")` solves my problem. Apologies !

Submit to CRAN

This will close https://github.com/ThinkR-open/gitlabr/issues/97

{gitlabr} migration to ThinkR-open

The only thing missing here is a new release to CRAN so that DESCRIPTION on CRAN is updated with the new url pointing to thinkr-open and not statnmap account.