Arvid Heise

I'm usually defining `typealias ShadowJar = com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar` in my multi-module projects to get rid of the import, but it can't get much crisper. Having some kind of an auto import...

You can achieve this by using: ``` tasks.withType { duplicatesStrategy = DuplicatesStrategy.EXCLUDE } ``` Your stuff is added first to the jar and everything with the same path that comes...

Oh I see the tests can't be run because it's based on an old branch. I'm rebasing myself.

Seems like the deleted arch unit rule was still needed. What was your intent when you deleted it?

Changes all LGTM. I'm running CI and merge when it's green. Thank you very much for this much needed fix!

Please check my comment here. https://issues.apache.org/jira/browse/FLINK-33545?focusedCommentId=17863737&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17863737 If everyone is sure that the current fix is addressing the actual issue, please go ahead.

QQ: do we need to sanatize/validate the prefix? I don't think we currently do it if you manually set the prefix, so it's probably not needed.

Reverted the deprecation of numFailed and added a config option for the retries. PTAL @fapaul

> While I understand the idea of the change, I wonder if it the right time or way. > > We just cut 2.0 and this is potentially a breaking...

> Thanks for addressing the comments % please double check that ` org.apache.flink.table.planner.runtime.stream.sql.TableSinkITCase.testSinkDisorderChangeLogWithRank` doesn't fail because of this change 👍 I double-checked: the test uses the `SinkOperator` wrapping the old...