Grzegorz Abramczyk
Grzegorz Abramczyk
From my point of wiew this is finished - please let me know if any changes are still required.
@NGPixel - I added commits handling Your suggestions
Merget latest changes from `dev` and did small fix.
Merged latest changes from `dev`
I'm using `inversify` in several of my projects and I will try to find some time to contribute. Is there any area to focus on or simply select open issues...
Actually after working on PR I found out that the hooks provided in opts are not only ignored if there ar no local/ global hooks - they are always ignored....
I will look into this - if I understand You correctly you suggest that * `@pnpm/pnpmfile` would return array of hooks for hooks that can be "merged" later * the...
What I found out the issue happens only with option `shared-workspace-lockfile = false` - with shared workspace lock the hook is handled correctly.
The line https://github.com/pnpm/pnpm/blob/f3fc6b540a55776b8ecbd8dcab29e7839c9a6cad/packages/plugin-commands-installation/src/recursive.ts#L292 coupled with https://github.com/pnpm/pnpm/blob/f3fc6b540a55776b8ecbd8dcab29e7839c9a6cad/packages/plugin-commands-installation/src/recursive.ts#L354 Causes hooks from opts to be discarded in favor of pnpmfile generated hooks before they can reach createReadPackageHook.
@zkochan one question - I found out that `config` module also uses `requireHooks` https://github.com/pnpm/pnpm/blob/f3fc6b540a55776b8ecbd8dcab29e7839c9a6cad/packages/config/src/index.ts#L525 And it is very hard for me to trace places where change in type (to array)...