Andy Mok comments

Results 5 comments of


                                            Andy Mok

namespace TYPE_NAMES and require the parent file

Bump. This is quite an important fix for our forked version of rbhive.

Idea: Don't return virtual attributes in attribute methods unless the ciphertext attribute is present

A tricky thing is if people do want virtual attributes with a ciphertext virtual attribute (not from an ActiveRecord column) ``` class User < ActiveRecord::Base # This is never saved...

fix: enumerize with string store accessor keys

Note to self, rebase after merging https://github.com/brainspec/enumerize/pull/450.

Allow users to provide their own storage client

+1 to supporting more [options](https://cloud.google.com/ruby/docs/reference/google-cloud-storage/latest/Google-Cloud-Storage#Google__Cloud__Storage_new_class_) to pass to `Google::Cloud::Storage`. In our repo, we created a subclass of `Shrine::Storage::GoogleCloudStorage` and overrode the method `#storage` to be able to pass it more...

feat: register store_attributes as attributes

Hey @palkan you haven't done this right? @RickCSong is a buddy and we can find someone to add the change you suggested!