3styleJam
3styleJam
It sounds like you want a P chart rather than an XmR chart, which is what `ptd_spc()` plots? It would be nice to have another function that plots a P...
> That is a really nice edge case [@3styleJam](https://github.com/3styleJam)! Obviously the way the code works is that the project name is concatenated after the directory. > > As a first...
> What if there was a directory parameter in the call to `create.project`? Yes a "project.directory" parameter would be good. It's default value could be the current working directory, and...
> This is breaking quite a bit of the functions when no directory is given. Can you please run that tests and see where it is breaking? Looking at the...
> Thanks. Let me know when the tests are passing! Many of the tests create a temporary file with the name `test_project` before calling: ```r suppressMessages(create.project(test_project)) ``` Which runs an...
I've made some more progress and now all that's left is 6 warnings. They are all within "test-migration.R" and they all happen at a call: ```r expect_warning(suppressMessages(load.project()), ...) ``` With...
> @3styleJam I'm wanting to push a new version to CRAN soon. Should I wait for the PR to be finished or push without it? @KentonWhite Sorry for the delay....
> @3styleJam if you are working on this I can wait. Like to have new features at once rather than 2 releases close to each other. I understand. I am...
@KentonWhite I think I have managed to clear the remaining warnings, however I did this by modifying a couple of tests which you may want to double check (see commit...
> Hi @3styleJam! > > I reviewed your changes to "test-cache.R" and they look good to me. :) > > Just one remark concerning the new `project.directory` parameter: You added...