Bronson Bata

Results 13 comments of Bronson Bata

I went ahead and made a PR #82 , this weekend. Please let me know if we think this addresses the request or if you'd like to see changes. @jannesiera...

> When I build this branch locally, it seems to build Paket.Core with FSharp.Core 8, then build the integration tests with FSharp.Core 5, and then v5 is the one that...

# Paket Lock Diff Report This report was generated via [Paket Lock Diff](https://paket-lock-diff.azurewebsites.net/?olderLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2Fmaster%2Fpaket.lock&newerLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2F5668e58b4461b033089457e49799061a3cad98a8%2Fpaket.lock) ## Additions - (0) ## Removals - (5) * FSharpDepManagerExtension - (1) * [FSharp.Core - 5.0.0](https://www.fuget.org/packages/FSharp.Core/5.0.0/) *...

I believe these changes should be good to go. The failing tests seemed normal as mentioned in the discussion on #4272. Let me know if I can update anything else...

@smoothdeveloper Sorry, I had VSCode set to format on save! Made all the necessary changes. Good call on the framework restrictions 😎

Actually spoke too soon. Looking into some errors

# Paket Lock Diff Report This report was generated via [Paket Lock Diff](https://paket-lock-diff.azurewebsites.net/?olderLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2Fmaster%2Fpaket.lock&newerLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2Fb5ffdc8e2e7951d8acc879ca11cf63597ac1f2e9%2Fpaket.lock) ## Additions - (0) ## Removals - (46) * FSharpDepManagerExtension - (1) * [FSharp.Core - 5.0.0](https://www.fuget.org/packages/FSharp.Core/5.0.0/) *...

@smoothdeveloper It appears adding the framework restrictions and removing the Newtonsoft redirect is causing build issues on the build server. Have any ideas as to what the errors could mean?...

I ended up reverting the changes involving the framework restrictions in the paket.dependencies since they were causing issues in the CI at the moment. I'd say we try to tackle...

Here is the paket.lock diff after reverting the changes # Paket Lock Diff Report This report was generated via [Paket Lock Diff](https://paket-lock-diff.azurewebsites.net/?olderLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2Fmaster%2Fpaket.lock&newerLockFileUrl=https%3A%2F%2Fraw.githubusercontent.com%2Ffsprojects%2FPaket%2F6dfd384b0265caaf7e3ff27d78babe72972b9a93%2Fpaket.lock) ## Additions - (0) ## Removals - (5)...