Laura Brown

Results 24 comments of Laura Brown

Hey @gui-gui, Could you link to the forked slate-tools repo? I have a couple of slate projects lingering around, and I ran into this issue after upgrading my computer too....

> Hey @gui-gui, Could you link to the forked slate-tools repo? I have a couple of slate projects lingering around, and I ran into this issue after upgrading my computer...

@dzucconi @alloy so how exactly should this work? counts has many sub-fields, so we would have one called `artwork` that takes a filter, from the same set of Enums as...

@mzikherman what's your two cents? is what i'm saying making sense? personally i think it's kind of weird to have the value for `counts.artworks` change based on parameters passed to...

We do in fact take advantage of the string formatting and label parameters in a few places, just in force: https://github.com/artsy/force/blob/master/apps/artwork/components/artist_artworks/query.coffee#L7 https://github.com/artsy/force/blob/master/apps/artwork/components/partner/query.coffee#L21 https://github.com/artsy/force/blob/master/apps/artwork/components/partner_artworks/query.coffee#L7 perhaps we should make a Type that...

as well as here: https://github.com/artsy/microgravity/blob/master/apps/artwork/components/related_artworks/queries/partner_query.coffee#L7

We could also add a `not_for_sale_works` `count` field that does the math for `not_for_sale_works = artist.counts.artworks - artist.counts.for_sale_works` _before_ calling `numeral`

@alloy in the case of `not_for_sale_works`, if you requested that count without the format or value params, wouldnt the json response for that field just be an integer as far...

I'm confused -- what is the problem TypeScript would have with these values: ![screen shot 2017-02-16 at 5 47 46 pm](https://cloud.githubusercontent.com/assets/3171662/23031116/2607349c-f470-11e6-85ad-2729f27a19da.png)