19priyadhingra

Results 17 comments of 19priyadhingra

> Thanks for the efforts. Could we remove the ticket link from the PR title, it should be automatically linked using "Autolink" > > We need to add documentation for...

Thanks for the feedback @vahmed-hamdy. I replied to all the feedback except the documentation one which is still in progress. Is there a package where I suppose to add the...

> @19priyadhingra 👋 I've had the opportunity to build and try this connector. Want to share some feedback: > > * Currently, it looks like all messages are encoded with...

> Thanks @19priyadhingra for addressing the comments, could we fix the spotless violations as mentioned above? Yes @vahmed-hamdy , I am trying hard on it. As attached in above screenshots,...

> Thanks @19priyadhingra for addressing the comments, could we fix the spotless violations as mentioned above? I was able to finally make "spotless" work for my local workspace post downgrading...

> Thanks for the efforts. Could we remove the ticket link from the PR title, it should be automatically linked using "Autolink" > > We need to add documentation for...

> > Would you recommend keeping it normal, String? > > Yes! And if someone needs base64 encoding they can encode it in the `SerializationSchema`. > > > I have...

> We seem to be having quite a few `.` in the class folders. Can we change them to `/` instead? e.g. `[flink-connector-aws](https://issues.apache.org/jira/browse/FLINK-connector-aws)/[flink-connector-sqs](https://issues.apache.org/jira/browse/FLINK-connector-sqs)/src/test/java/org.apache.flink/connector.sqs/sink/SqsExceptionClassifiersTest.java Good catch! Fixed

> It'd also be great to mention what permissions are needed for this connector to work. E.g., is `sqs:SendMessage` sufficient? Good point!, Yes, `sqs:SendMessage` is sufficient, updated the same in...

> Hi, when is this planned to be released? @19priyadhingra Unfortunately, right now It is stuck on getting approval, no actions pending at my end at this stage.