James Wright
James Wright
FWIW, this is done for Closure Library: https://github.com/google/closure-library/blob/a6c80eff2422aadb3759608a97c8bb49e8442d3b/closure/goog/base.js#L4 @mathiasbynens it might be good to run this past OSPO? There's also no Copyright notice for JSBI, maybe that needs to updated...
Sorry for the delayed response - I realize I had drafted a response but never sent it. My personal opinion is that I would rather refuse valid patterns in favour...
It looks like you might already be planning breaking changes in #71 - I suppose if this did happen it would end up only being available here? The difference is...
I'm interested - I'll try and take a look at this this week or next.
As mentioned [in the script](https://github.com/google/closure-library/blob/master/closure/bin/build/closurebuilder.py#L262-L268), Closure Compiler itself is better able to understand dependencies than this script. You should be able to migrate this workflow over to a direct compiler...
As the file overview comment indicates, this might be the result of data missing from the CLDR dataset: https://github.com/google/closure-library/blob/39cb429b2e3c12170270b1e92ae2fbaeec007d75/closure/goog/i18n/numberformatsymbols.js#L9 I would guess the correct file to get updated would be...
I filed https://unicode-org.atlassian.net/browse/CLDR-14591 to see if this can get fixed upstream.
A quick update in case you weren't subscribed to that issue: it seems that this is fixed in CLDR 40. I'm not sure when that will land in Closure Library...
This might be fixed: https://github.com/google/closure-library/blob/8889f54a9c15153c455d97d3847ad6e827370a6c/closure/goog/i18n/numberformatsymbols.js#L1973 Generally, all this feedback should be reported / debated over in a CLDR ticket, as Closure Library (and Flutter and many many other products) will...
Thanks for reporting this. We generate our documentation using the [JsDossier project](https://github.com/jleyba/js-dossier), and it seems that this file is being skipped entirely due to [this line](https://github.com/jleyba/js-dossier/blob/e1d14349dd4d6132b16fef6c56dfe4b33410ca33/src/java/com/github/jsdossier/DocumentableTypePredicate.java#L41) that checks for implicit...