0xmiroslav

Results 111 comments of 0xmiroslav

https://github.com/Expensify/App/issues/12436 is closed in favor of this PR. So I think [this](https://github.com/Expensify/App/issues/12436#issuecomment-1304804636) needs to be tested here. I am sure that test will happen but just to confirm! cc: @mananjadhav

### **Proposal** https://github.com/Expensify/expensify-common/blob/a71aad37aaba2b43b3a2d2f4be8052b025b265d3/lib/ExpensiMark.js#L471-L477 ```diff this.htmlToMarkdownRules.forEach((rule) => { // Pre-processes input HTML before applying regex if (rule.pre) { generatedMarkdown = rule.pre(generatedMarkdown); } - generatedMarkdown = generatedMarkdown.replace(rule.regex, rule.replacement); + generatedMarkdown = generatedMarkdown.replace(rule.regex,...

1. ```diff - generatedMarkdown = generatedMarkdown.replace(rule.regex, rule.replacement); + generatedMarkdown = generatedMarkdown.replace(rule.regex, rule.replacement).trim(); ``` Explanation: https://github.com/Expensify/expensify-common/blob/a71aad37aaba2b43b3a2d2f4be8052b025b265d3/lib/ExpensiMark.js#L256 ``` return `\n${resultString}\n`; ``` `\n` is added at the beginning of and at the end...

I agree 2nd step is beyond the scope of this GH. And regarding regression test, 1st step also fixes other similar issues along with this GH. i.e. `# This is...

> In the video, the blank line still appears no? Is it before the fix? @MonilBhavsar yes, exactly. I explained another bug (i.e. html header tag) before the fix. After...

> could you please explain what exactly you're trying to fix in your second proposal ``` Text1 > Text2 ``` It shows like this when try to edit: (one line...

### **Proposal** **RCA**: preventDefault() is triggered on Enter key of [TextInput](https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js#L301) because of [OptionsSelector](https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceInvitePage.js#L267) (to select members) which overrides keyboard shortcuts of Enter, Arrow up/down keys. NOTE: On desktop, Shift+Enter...

### **Proposal** This is caused by https://github.com/Expensify/App/pull/8375 which fixes https://github.com/Expensify/App/issues/8007 **Solution:** `.replace(/\./g, '')` is only for email search, so we can remove that only when search for chat room names...

### **Proposal** https://github.com/Expensify/App/blob/main/src/components/Composer/index.js#L297 ```diff if (embeddedImages.length > 0 && embeddedImages[0].src) { + if (embeddedImages[0].dataset && embeddedImages[0].dataset.stringifyType === 'emoji') { + const plainText = event.clipboardData.getData('text/plain'); + this.paste(Str.htmlDecode(plainText)); + return; + }...

This issue is for web only. It's not reproducible on native. Here's working video: https://user-images.githubusercontent.com/97473779/200060239-2c71127c-cdf2-4bde-a442-cdea09f2fb6a.mp4