0xCourtney

This would probably go well inside the `lib` package or it could be hardhat-plugin 🤔 . Was there anything that stopped this from being implemented?

Just to summarize the problem statement here. The Diamond proxy is becoming an increasingly popular standard but managing deployments and upgrades is a challenging task with limited developer tooling available....

I was just thinking about this as well. Any updates here? Preferences on workflows? We use one for automated tests, linter checks, and code coverage on Knox Finance. Adding an...

For both `grantRole` and `revokeRole` checks can be performed ahead of time if a bool or revert is desirable. I like the third option or leaving it as is.

These data structures can accommodate the three types suggested above. The AVL tree structure has an `Index` struct which stores data about the tree such as the root node id,...

Does it make sense to write separate contracts for ERC2981? I've made a few observations since I started looking into this one. 1. The spec was written so ERC2981 can...

> 1. Can you think of a good place to put it other than ERC721/royalties/ and ERC1155/royalties/? `utils` seems appropriate given it's not specific to any token nor is it...

I was just thinking about this, looking at some of the other ERC's like ERC165, ERC173, etc they all live within their respective domains, only makes sense to follow that...

The `require` statement should be changed to revert, I will do this after #139 is merged.

Thanks for the feedback, I would agree that having the `getSelector`, `get` and `remove` functions are potential enhancements here. The `getSelectors` and `getSignatures` functions were actually copied from Nicks [Diamond...