micro icon indicating copy to clipboard operation
micro copied to clipboard

Search and replace improvements

Open supbish opened this issue 7 years ago • 2 comments

See comments on affected tickets for details...

  • make Search a method of View; fixes #1134
  • expand captures during replace; fixes #1115
  • Add replace in selection; fixes #1098
  • Non-modal search; fixes #1150 and part of #941

supbish avatar Aug 20 '18 06:08 supbish

Replace in selections works pretty nicely, but can probably be improved with some visual cues. Needs some documentation updates also.

The range that's searched is based on lines, not characters... so if anything on a line is selected with the main cursor, that entire line is searched. It's a pretty good usefulness-to-complexity tradeoff, but a visual cue would make the behavior more obvious. I'm thinking of maybe coloring the affected lines with the "cursor-line" color, but that'll probably require exposing some stuff to the view.

Long story short, the functionality is there, so feel free to test it, and pull it if you want; I'll update docs and visual cues at some point either way.

supbish avatar Aug 21 '18 09:08 supbish

What was the verdict?

grinapo avatar Sep 02 '24 11:09 grinapo