OpenAPI icon indicating copy to clipboard operation
OpenAPI copied to clipboard

some code I added to make OpenApi reader work on my files

Open bocasti opened this issue 5 years ago • 5 comments

bocasti avatar Aug 04 '20 08:08 bocasti

I don't get what this should fix. The primitive schema should not be visited because it rather considered to be abstract. As for the OALink this covers existing bugs. Can you provide me with the file you want to read instead?

noha avatar Aug 04 '20 09:08 noha

So I added a test for each case:

  • testParsingSchemaMinItems => for the #minItems: method
  • testParsingResponseWithLinks => for the OALink mapping
  • testParsingOpenAPIWithEnum => for the #acceptOpenApi: method

bocasti avatar Aug 04 '20 15:08 bocasti

I don't get why you make extension methods here for JSONSchema. Look at https://github.com/zweidenker/JSONSchema/pull/40 that adds minItems and maxItems. What else needs to be done?

noha avatar Aug 04 '20 15:08 noha

Can remove the minItem and json schema stuff please?

noha avatar Aug 06 '20 12:08 noha

Ok, i just

  • removed one useless test related to this #miItems: stuff
  • removed my "hacks" in OALink and PrimitiveSchema

There should now be 2 test failing, which i think highlights 2 issues

bocasti avatar Aug 06 '20 13:08 bocasti