node-zwave-js icon indicating copy to clipboard operation
node-zwave-js copied to clipboard

feat(config): add ZSE70 device file; Add additional templates to Zooz template file

Open akennerly opened this issue 1 year ago • 6 comments

Add Zooz ZSE70

akennerly avatar Dec 12 '24 17:12 akennerly

I'm at loss in seeing where the lint test is failing.

akennerly avatar Dec 12 '24 19:12 akennerly

I'm at loss in seeing where the lint test is failing.

You can run yarn fmt in your dev environment and it will fix the formatting issue for you. The lint command that is failing is yarn fmt:check but it hides the output. yarn exec dprint check will show the entire output, which is just the filename and diff output.

diff --git a/packages/config/config/devices/0x027a/zse70.json b/packages/config/config/devices/0x027a/zse70.json
index c54a9a7..6ca77d1 100644
--- a/packages/config/config/devices/0x027a/zse70.json
+++ b/packages/config/config/devices/0x027a/zse70.json
@@ -110,11 +110,11 @@
 			"minValue": 0,
 			"defaultValue": 2,
 			"options": [
-			{
-				"label": "Disable",
-				"value": 0
-			}
-		]
+				{
+					"label": "Disable",
+					"value": 0
+				}
+			]
 		},
 		{
 			"#": "12",
@@ -144,7 +144,6 @@
 			"#": "18",
 			"$import": "templates/zooz_template.json#lux_report_frequency"
 		}
-		
 	],
 	"metadata": {
 		"wakeup": "Press the Z-Wave button to wake the device up. The LED will start flashing.",
$ yarn exec dprint check
from /workspaces/node-zwave-js/packages/config/config/devices/0x027a/zse70.json:
110 110| →→→"minValue":·0,
111 111| →→→"defaultValue":·2,
112 112| →→→"options":·[
    113|-→→→{
    114|-→→→→"label":·"Disable",
    115|-→→→→"value":·0
    116|-→→→}
    117|-→→]
113    |+→→→→{
114    |+→→→→→"label":·"Disable",
115    |+→→→→→"value":·0
116    |+→→→→}
117    |+→→→]
118 118| →→},
119 119| →→{
120 120| →→→"#":·"12",
...
144 144| →→→"#":·"18",
145 145| →→→"$import":·"templates/zooz_template.json#lux_report_frequency"
146 146| →→}
    147|-→→
147 148| →],
148 149| →"metadata":·{
149 150| →→"wakeup":·"Press·the·Z-Wave·button·to·wake·the·device·up.·The·LED·will·start·flashing.",
--
Found 1 not formatted file.

kpine avatar Dec 12 '24 23:12 kpine

Btw, I created a pull request for this already a few weeks ago. Hasn't been merged yet though.

#7405

hceuterpe avatar Dec 13 '24 18:12 hceuterpe

Btw, I created a pull request for this already a few weeks ago. Hasn't been merged yet though.

Your link got mangled, it's #7405. Which is confusing because your PR doesn't add any new files. Turns out the actual PR adding the config is at https://github.com/zwave-js/node-zwave-js/pull/7381, which would need to be merged first.

kpine avatar Dec 13 '24 18:12 kpine

I found https://github.com/zwave-js/node-zwave-js/pull/7496 first, so the work will continue there.

AlCalzone avatar Jan 10 '25 13:01 AlCalzone

Marking this as draft for now. I like the templating changes, but the ZSE70 has been merged in the other PR.

AlCalzone avatar Mar 12 '25 09:03 AlCalzone