fix:Rework and enable tests for Merels. #433
Rework and enable tests for Merels. #433
Fixes: #433
This PR fixes and enables the test suite for the Merels bot by resolving import issues, adjusting test execution paths, and ensuring compatibility with the Zulip bot framework.
Changes:
- Fixed relative import errors in
test_merels.py - Updated test paths to be compatible with
zulip-run-bot - Verified correct game logic execution with sample test cases
How did you test this PR?
- Ran
pytest zulip_bots/bots/merels/to verify all tests pass - Manually checked bot response output in a Zulip development environment
Self-review checklist
- [x] Self-reviewed the changes for clarity and maintainability (variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
- [x] Explains differences from previous plans (e.g., issue description).
- [ ] Highlights technical choices and bugs encountered.
- [ ] Calls out remaining decisions and concerns.
- [ ] Automated tests verify logic where appropriate.
Individual commits are ready for review (see commit discipline).
- [x] Each commit is a coherent idea.
- [x] Commit message(s) explain reasoning and motivation for changes.
Completed manual review and testing of the following:
- [ ] Visual appearance of the changes.
- [x] Responsiveness and internationalization.
- [x] Strings and tooltips.
- [x] End-to-end functionality of buttons, interactions and flows.
- [x] Corner cases, error conditions, and easily imagined bugs.
Hello @avijitdas126, it seems like you have referenced #433 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.
Please run git commit --amend in your command line client to amend your commit message description with Fixes #433..
An example of a correctly-formatted commit:
commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date: Sat Mar 18 13:42:40 2017 -0700
pull requests: Check PR commits reference when issue is referenced.
Fixes #51.
To learn how to write a great commit message, please refer to our guide.
@amanagr could you please review this PR?
Hi @avijitdas126 thanks for working on this. Please read https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html
Thanks @amanagr for the reference! I've gone through Zulip's commit discipline guidelines. I'll ensure my commits are structured as minimal, self-contained units, with proper formatting and clear commit messages. Let me know if there are any specific points you'd like me to focus on!