python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Slack bridge: Implement multiple channels bridges.

Open rht opened this issue 4 years ago • 5 comments

rht avatar Nov 28 '21 06:11 rht

@PIG208 thank you for the review!

rht avatar Sep 29 '22 09:09 rht

I have implemented the requests in the 3rd commit.

rht avatar Sep 29 '22 10:09 rht

I have implemented the requests and tidied the commits.

rht avatar Sep 30 '22 12:09 rht

@rht I'm not sure how much detail is expected here before merging, but other than the checks above (one needing fixing - static-analysis), has this been tested and if so how?

neiljp avatar Oct 01 '22 00:10 neiljp

The static analysis test has been fixed.

has this been tested and if so how?

I tested this on a live Slack workspace and CZO. I have retested just now, just in case if the refactor causes any regression. See https://chat.zulip.org/#narrow/stream/7-test-here/topic/.3C-.20slack-bridge.20general and https://chat.zulip.org/#narrow/stream/7-test-here/topic/.3C-.20slack-bridge.20general

rht avatar Oct 01 '22 01:10 rht

Merged, thanks @rht!

timabbott avatar Oct 19 '22 22:10 timabbott