python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

twitter_bot: Solve retweet issue.

Open orientor opened this issue 5 years ago • 5 comments

The twitter bot initially posted all kind of tweets. Change it so that on encountering a retweet either post the original tweet if it hasn't been posted before. Else try to edit the number of retweets in the message of the original tweet.

orientor avatar Mar 21 '20 15:03 orientor

From my reading of the current state of the PR, there is no adding a number of retweets in the body of the message yet (a). What happens is that the message is being edited with the message_id pointing to the latest message. Is feature (a) too unwieldy to implement?

rht avatar Mar 21 '20 17:03 rht

From my reading of the current state of the PR, there is no adding a number of retweets in the body of the message yet (a). What happens is that the message is being edited with the message_id pointing to the latest message. Is feature (a) too unwieldy to implement?

@rht I am storing the twitter id: message id key-value pairs for tweets that have been posted in the config file. So message_id will point to the older message and that will be edited. I didn't understand the "pointing to latest message" part. And if the message is a retweet I am adding the number of retweets to the url variable. I will add the retweets part to the general tweet too.

orientor avatar Mar 21 '20 18:03 orientor

Screenshot from 2020-03-21 23-57-20 @rht Added number of retweets to all messages.

orientor avatar Mar 21 '20 18:03 orientor

Perhaps it will be feasible to use bot storage to store the key-value pairs.

PIG208 avatar Jun 14 '21 15:06 PIG208

Heads up @orientor, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 24 '21 19:08 zulipbot