zug
zug
@rndquu, I've considered EnumerableMap but I still think the native mapping approach is more efficient. The biggest gas cost in this contract happens when you insert/remove a payee, since all...
Please let me know what is your preferred approach, if you want more strict arguments in favor of using native mappings please let me know, I can further elaborate why...
waiting on PR review
what I've done is run another server&builder, using wrangler only for cloudflare related functions, in my case I use esbuild
@rndquu Here are the QAs, new contract is working great now, but I can't reproduce a collision at my local fork for some reason. > 1. No storage updates, CI...
@rndquu you were right. Here is the QA: [1. Should skip new contract](https://github.com/ubiquity/ubiquity-dollar/pull/974/commits/7bb1c7bc1d009ec6fc62c94d48b6fa06034d070a) [2. Should skip new contract even if changed in a later commit](https://github.com/ubiquity/ubiquity-dollar/pull/974/commits/a6477bcd438a22aaef6c867dba92da226b7f51d8) [3. Should fail if core...
If you need a quick way to see workflow runs per commit you can use GitHub's [CLI](https://github.com/cli/cli) with a version younger than a year, since this change was included in...
I can't QA properly because all artifacts from `development` have expired. `Error: Error: No workflow run found with an artifact named "development.packages_contracts_src_dollar_libraries_LibAppStorage.sol-LibAppStorage.json"`. We could either: 1. Run `core-contracts-storage-check.yml` and `diamond-storage-check.yml`...
> Adding workflow dispatch seems like a simple and good idea. Its just a line of code. Won't really work since `core-contracts-storage-check.yml` and `diamond-storage-check.yml` filter by changed files only. I've...
waiting on PR review