react-native-sound icon indicating copy to clipboard operation
react-native-sound copied to clipboard

React Native 0.71.0 incompatibility

Open jakequade opened this issue 2 years ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

I'm upgrading a React Native project from 0.68.7 version to 0.71.0, and the RNSound.m does not build out of the box.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-sound/RNSound/RNSound.m b/node_modules/react-native-sound/RNSound/RNSound.m
index df3784e..17e5894 100644
--- a/node_modules/react-native-sound/RNSound/RNSound.m
+++ b/node_modules/react-native-sound/RNSound/RNSound.m
@@ -1,10 +1,5 @@
 #import "RNSound.h"
-
-#if __has_include("RCTUtils.h")
-#import "RCTUtils.h"
-#else
 #import <React/RCTUtils.h>
-#endif
 
 @implementation RNSound {
     NSMutableDictionary *_playerPool;

jakequade avatar Nov 13 '23 00:11 jakequade

Could you please open a PR ?

RomualdPercereau avatar Nov 15 '23 09:11 RomualdPercereau