metadata icon indicating copy to clipboard operation
metadata copied to clipboard

Failing test prevents nix packaging

Open leana8959 opened this issue 9 months ago • 2 comments

Hello,

I came across this project and I noticed it's failing to be packaged in the nixpkgs registry because one test is failing. The compilation works fine.

I'm getting the following result:

... suceeding tests elided

failures:

---- aac_he_aac stdout ----

thread 'aac_he_aac' panicked at tests/integration_test.rs:79:1:
assertion `left == right` failed
  left: "Filename:               aac_he.aac\nFile size:              1396 (1.40KB, 1.37KiB)\nContainer format:       Raw ADTS AAC\nDuration:               00:00:00.23\nBit rate:               48 kb/s\nStreams:\n    #0: Audio (und), AAC (HE-AAC v2), 44100 Hz, stereo, 48 kb/s\n\n"
 right: "Filename:               aac_he.aac\nFile size:              1396 (1.40KB, 1.37KiB)\nContainer format:       Raw ADTS AAC\nDuration:               00:00:00.23\nBit rate:               48 kb/s\nStreams:\n    #0: Audio (und), AAC (LC), 44100 Hz, stereo, 48 kb/s\n\n"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    aac_he_aac

With a little investigation, I noticed that ffmpeg reports the file is AAC (LC) and not AAC (HE-AAC).

ffmpeg output
$ ffmpeg -i tests/data/aac_he_aac/aac_he.aac
ffmpeg version 7.1.1 Copyright (c) 2000-2025 the FFmpeg developers
  built with gcc 14.2.1 (GCC) 20250322
  configuration: --disable-static --prefix=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1 --target_os=linux --arch=x86_64 --pkg-config=pkg-config --enable-gpl --enable-version3 --disable-nonfree --disable-static --enable-shared --enable-pic --disable-thumb --disable-small --enable-runtime-cpudetect --disable-gray --enable-swscale-alpha --enable-hardcoded-tables --enable-safe-bitstream-reader --enable-pthreads --disable-w32threads --disable-os2threads --enable-network --enable-pixelutils --datadir=/nix/store/x1318jzv76xpiaqdyxq9awcd7mfy25zz-ffmpeg-7.1.1-data/share/ffmpeg --enable-ffmpeg --enable-ffplay --enable-ffprobe --bindir=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1-bin/bin --enable-avcodec --enable-avdevice --enable-avfilter --enable-avformat --enable-avutil --enable-postproc --enable-swresample --enable-swscale --libdir=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1-lib/lib --incdir=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1-dev/include --enable-doc --enable-htmlpages --enable-manpages --mandir=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1-man/share/man --enable-podpages --enable-txtpages --docdir=/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ffmpeg-7.1.1-doc/share/doc/ffmpeg --enable-alsa --enable-amf --enable-libaom --disable-libaribb24 --disable-libaribcaption --enable-libass --disable-avisynth --enable-libbluray --disable-libbs2b --enable-bzlib --disable-libcaca --disable-libcdio --disable-libcelt --disable-chromaprint --disable-libcodec2 --disable-cuda --enable-cuda-llvm --disable-cuda-nvcc --enable-cuvid --enable-libdav1d --disable-libdc1394 --enable-libdrm --disable-libdvdnav --disable-libdvdread --disable-libfdk-aac --enable-ffnvcodec --disable-libflite --enable-fontconfig --enable-libfontconfig --enable-libfreetype --disable-frei0r --enable-libfribidi --disable-libgme --enable-gnutls --disable-libgsm --enable-libharfbuzz --enable-iconv --disable-libilbc --disable-libjack --disable-libjxl --disable-libkvazaar --disable-ladspa --disable-liblc3 --disable-liblcevc-dec --disable-lcms2 --enable-lzma --disable-metal --disable-libmfx --disable-libmodplug --enable-libmp3lame --disable-libmysofa --disable-libnpp --enable-nvdec --enable-nvenc --disable-openal --enable-opencl --disable-libopencore-amrnb --disable-libopencore-amrwb --disable-opengl --disable-libopenh264 --enable-libopenjpeg --enable-libopenmpt --enable-libopus --disable-libplacebo --enable-libpulse --disable-libqrencode --disable-libquirc --disable-librav1e --enable-librist --disable-librtmp --disable-librubberband --disable-libsmbclient --enable-sdl2 --disable-libshaderc --disable-libshine --disable-libsnappy --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --disable-librsvg --enable-libsvtav1 --disable-libtensorflow --enable-libtheora --disable-libtwolame --enable-libv4l2 --enable-v4l2-m2m --enable-vaapi --enable-vdpau --disable-libvpl --enable-libvidstab --disable-libvmaf --disable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-vulkan --disable-libvvenc --enable-libwebp --enable-libx264 --enable-libx265 --disable-libxavs --disable-libxcb --disable-libxcb-shape --disable-libxcb-shm --disable-libxcb-xfixes --disable-libxevd --disable-libxeve --disable-xlib --enable-libxml2 --enable-libxvid --enable-libzimg --enable-zlib --disable-libzmq --enable-libzvbi --disable-debug --enable-optimizations --disable-extra-warnings --disable-stripping
  libavutil      59. 39.100 / 59. 39.100
  libavcodec     61. 19.101 / 61. 19.101
  libavformat    61.  7.100 / 61.  7.100
  libavdevice    61.  3.100 / 61.  3.100
  libavfilter    10.  4.100 / 10.  4.100
  libswscale      8.  3.100 /  8.  3.100
  libswresample   5.  3.100 /  5.  3.100
  libpostproc    58.  3.100 / 58.  3.100
[aac @ 0x2b3ae80] Estimating duration from bitrate, this may be inaccurate
Input #0, aac, from 'tests/data/aac_he_aac/aac_he.aac':
  Duration: 00:00:00.23, bitrate: 48 kb/s
  Stream #0:0: Audio: aac (LC), 44100 Hz, stereo, fltp, 48 kb/s
At least one output file must be specified

Thanks :)

leana8959 avatar May 06 '25 22:05 leana8959

Probably happens after another ffmpeg update. /cc @myclevorname

vcunat avatar May 28 '25 06:05 vcunat

I am stepping down as a Nixpkgs maintainer, so metadata needs adoption.

myclevorname avatar Jun 04 '25 16:06 myclevorname