rspec_api_documentation icon indicating copy to clipboard operation
rspec_api_documentation copied to clipboard

Support for rack 3.1.0

Open TeamNautilus opened this issue 1 year ago • 4 comments

Hello Zipmark,

we are Team Nautilus, and we would like to report an issue related to the rspec_api_documentation gem.

We are using Ruby 3.1.1 with the following Gemfile:

gem 'rails', '7.1.3'
gem 'rack', '3.0.11'
gem 'rspec_api_documentation', git: 'https://github.com/zipmark/rspec_api_documentation.git'

GIT
  remote: https://github.com/zipmark/rspec_api_documentation.git
  revision: d32bf17932a379052e8bb7540fc29ce7e72712ae
  specs:
    rspec_api_documentation (6.1.0)

and when we run the command rake docs:generate, everything works fine.

However, after updating the rack gem to version 3.1.0, we encounter the following error:

NoMethodError: 
    undefined method 'rewind' for nil:NilClass
        input.rewind

at rspec_api_documentation-d32bf17932a3/lib/rspec_api_documentation/client_base.rb#48.

Can you help us resolve this issue?

Thank you.

TeamNautilus avatar Jul 29 '24 12:07 TeamNautilus

I'm running into this as well with rspec_api_documentation 6.1.0, ruby 3.2.5, rails 7.1.3.4 and rack 3.1.7.

johanvdlaak avatar Aug 12 '24 11:08 johanvdlaak

In rack 3.0.11 last_request.env["rack.input"] has a value. After that it does not.

https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rackinput-is-no-longer-required-to-be-rewindable

Switching forks fixed the problem: gem 'rspec_api_documentation', github: 'SchoolKeep/rspec_api_documentation', ref: '13df1ac'

ERCubed avatar Aug 26 '24 16:08 ERCubed

Switching forks fixed the problem: gem 'rspec_api_documentation', github: 'SchoolKeep/rspec_api_documentation', ref: '13df1ac'

It works also for us, thank you!

TeamNautilus avatar Aug 28 '24 09:08 TeamNautilus

Can be fixed by https://github.com/zipmark/rspec_api_documentation/pull/541 it seems.

akostadinov avatar Feb 13 '25 10:02 akostadinov