rspec_api_documentation icon indicating copy to clipboard operation
rspec_api_documentation copied to clipboard

Add Support for Ruby 3.2

Open nicolaa opened this issue 3 years ago • 4 comments

https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/

Addresses https://github.com/zipmark/rspec_api_documentation/issues/505

nicolaa avatar Jan 13 '23 15:01 nicolaa

@nicolaa Thanks for the contribution. I hope this gets merged eventually.

Notably, the version number would need a new MAJOR version.

@cickes I don't think so. File.exist? is part of the core library since well before 2.0.0. https://ruby-doc.org/core-1.8.6/File.html#method-c-exist-3F So this change is in no way backwards incompatible.

schm avatar Apr 14 '23 08:04 schm

Looks like maybe https://github.com/stitchfix/rspec_api_documentation is the active fork to follow?

bf4 avatar Jun 14 '23 01:06 bf4

@oestrich @jakehow what's the maintenance status of this gem? Are you looking for new maintainers? It'd be quite important to get this trivial PR merged 😬

Thanks 🙌

santib avatar Sep 08 '23 18:09 santib

@oestrich @jakehow could you please accept this PR

apotema avatar Dec 01 '23 18:12 apotema

We just upgraded to Ruby 3.3.0 We'll be building off the https://github.com/stitchfix/rspec_api_documentation fork for now but might start our own or transition to rspec-openapi and rswag like others have

bf4 avatar Apr 19 '24 15:04 bf4

Hey good fellas, is there a good reason this PR is still not being merged? If the project is dead (which is a possibility considering the date of the last change made) no further questions will be asked :) Thanks! cc @oestrich @jakehow

vladveterok avatar Apr 23 '24 12:04 vladveterok

Project needs to be adopted

bf4 avatar Apr 23 '24 15:04 bf4

FWIW in https://github.com/rootstrap/rails_api_base we migrated to:

More info in https://github.com/rootstrap/rails_api_base/blob/main/docs/api_documentation.md

santib avatar Apr 23 '24 15:04 santib

These are some great libs @santib . But it would be good to have this lib back.

apotema avatar Apr 23 '24 16:04 apotema

@vladveterok @bf4 lots of requests for maintenance and little volunteering to do it... I don't think this PR passed travisCI originally which is why it was not merged quickly. Travis now requires payment even on free plan which is probably why it's been removed. I am not sure if there is an alternative these days for OSS CI builds that is still free.

Happy to add anyone who wants to push some of these items forward ... @bf4 ?

jakehow avatar Apr 23 '24 18:04 jakehow

@jakehow Sure. I'll make a github actions test matrix pr on Wednesday if no one else has yet. (I'm afk right now)

bf4 avatar Apr 23 '24 19:04 bf4