zingg icon indicating copy to clipboard operation
zingg copied to clipboard

TestGetAs is slow

Open sonalgoyal opened this issue 3 years ago • 2 comments

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.14 s - in zingg.hash.TestGetAs

4 seconds is way too long for this test. investigate and suggest what needs to change

sonalgoyal avatar Jul 16 '22 05:07 sonalgoyal

here are the slow ones for me

[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.433 s - in zingg.similarity.function.TestNumbersJaccardFunction [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.325 s - in zingg.util.TestDSUtil [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.415 s - in zingg.hash.TestGetAs Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.455 s - in zingg.documenter.TestStopWordsDocumenter Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.14 s - in zingg.preprocess.TestStopWords

sonalgoyal avatar Jul 16 '22 05:07 sonalgoyal

testgetas setup needs to improve. have separate dfs for int and double. have dfs per case, with 2-3 values max so that long for loops can be avoided

sonalgoyal avatar Jul 16 '22 05:07 sonalgoyal

This seems to have been fixed and any time being taken is by ZinggSparkTester to set up session etc. No changes needed.

vikasgupta78 avatar Mar 23 '23 06:03 vikasgupta78