ZnDraw icon indicating copy to clipboard operation
ZnDraw copied to clipboard

`vis.register_modifier` open questions

Open PythonFZ opened this issue 2 years ago • 0 comments

  • [ ] what happens if the Python kernel closes
  • [ ] what happens if the page is reloaded (modifiers for given token should remain, if no token all modifiers should remain)
  • [ ] vis.register(cls, run_kwargs: dict) for passing e.g. ML models to the cls.run as kwargs
  • [ ] remove method from each entry, including enums like in moldiff - if we have to modify them anyway, can't we add the method automatically?
  • [ ] pass vis object to the modifers run method - or have self.vis ?
  • [ ] using register_modifier twice, will remove the first one.
  • [ ] non-default modifiers should be able to have the same name.
  • [ ] What about selection / analysis
  • [ ] with default=True the modifier still uses self.<attribute> which will not be correct!
  • [ ] properly allow to register a modifier without a token (might already be fine the way it is.)

PythonFZ avatar Nov 03 '23 17:11 PythonFZ