knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

Faiss: Remove duplicate NegativeDistanceComputer instances

Open alexanderguzhva opened this issue 1 year ago • 3 comments

Corresponding faiss baseline PR: https://github.com/facebookresearch/faiss/pull/3450 /kind improvement

alexanderguzhva avatar May 16 '24 17:05 alexanderguzhva

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

mergify[bot] avatar May 16 '24 17:05 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.04%. Comparing base (3c46f4c) to head (0e0aa57). Report is 96 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #571       +/-   ##
=========================================
+ Coverage      0   70.04%   +70.04%     
=========================================
  Files         0       67       +67     
  Lines         0     4597     +4597     
=========================================
+ Hits          0     3220     +3220     
- Misses        0     1377     +1377     

see 67 files with indirect coverage changes

codecov[bot] avatar May 16 '24 18:05 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 21 '24 02:05 sre-ci-robot

superceded by #663

alexanderguzhva avatar Jun 24 '24 23:06 alexanderguzhva