Faiss: Remove duplicate NegativeDistanceComputer instances
Corresponding faiss baseline PR: https://github.com/facebookresearch/faiss/pull/3450 /kind improvement
@alexanderguzhva 🔍 Important: PR Classification Needed!
For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
- If you're fixing a bug, label it as kind/bug.
- For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
- Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
- Adjusting APIs or changing functionality? Go with kind/feature.
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #
Thanks for your efforts and contribution to the community!.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.04%. Comparing base (
3c46f4c) to head (0e0aa57). Report is 96 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #571 +/- ##
=========================================
+ Coverage 0 70.04% +70.04%
=========================================
Files 0 67 +67
Lines 0 4597 +4597
=========================================
+ Hits 0 3220 +3220
- Misses 0 1377 +1377
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alexanderguzhva, Presburger
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Presburger]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
superceded by #663