zig icon indicating copy to clipboard operation
zig copied to clipboard

fetch: Keep .lazy = true

Open der-teufel-programming opened this issue 1 year ago • 2 comments

Solves #19725

der-teufel-programming avatar Apr 30 '24 12:04 der-teufel-programming

This seems like a wrong way to do it. If we currently have guarantees that zig fetch --save <url> only needs to change the url and the hash, I think a better implementation is to change the url and the hash and to not touch any other fields.

The way this PR is done, it only works in current context, what if in the future another field is introduced for another use-case. It just doesn't seem practical to keep changing it on every new field that is added increasing maintenance burden.

But that's just my 2 cents. Maybe some core team member can chime in and give feedback.

rupakhetibinit avatar Apr 30 '24 13:04 rupakhetibinit

I've changed the implementation to now only touch the hash and location fields when updating dependencies

der-teufel-programming avatar May 23 '24 11:05 der-teufel-programming

Thanks!

andrewrk avatar Sep 24 '24 20:09 andrewrk