zig icon indicating copy to clipboard operation
zig copied to clipboard

std.builtin.panic(uefi): usability improvements

Open fifty-six opened this issue 1 year ago • 7 comments

Inspired by the review in #16094. cc @wooster0?

fifty-six avatar Feb 16 '24 19:02 fifty-six

Are there any blockers for this - or did it just fall into backlog? Not a huge deal either way, but it's been a bit so I wanted to check.

fifty-six avatar Jul 10 '24 06:07 fifty-six

Oh whoops, just me writing the wrong thing down — I'll rewrite the commit description

fifty-six avatar Jul 15 '24 22:07 fifty-six

Fixed that - and rebased onto the current master commit

fifty-six avatar Jul 16 '24 16:07 fifty-six

Could you also give a quick reasoning as to why you want to do so? (Maybe as a comment in the code?)

Vexu avatar Jul 16 '24 20:07 Vexu

Yeah sure, added.

fifty-six avatar Jul 17 '24 02:07 fifty-six

+- test-fmt
   +- zig fmt --check failure
error: /home/ci/actions-runner1/_work/zig/zig/lib/std/builtin.zig: non-conforming formatting

You need to fix the formatting.

Vexu avatar Jul 22 '24 07:07 Vexu

Ah ok

fifty-six avatar Jul 22 '24 07:07 fifty-six