zig icon indicating copy to clipboard operation
zig copied to clipboard

implement astgen union + enum & update behavior tests

Open Rexicon226 opened this issue 2 years ago • 4 comments

i believe this finishes up #17916.

might have missed some cases, please let me know!

Rexicon226 avatar Nov 22 '23 10:11 Rexicon226

@mlugg sorry to bother :D whenever you have a chance to review

Rexicon226 avatar Nov 24 '23 01:11 Rexicon226

will merge the latest changes from master to re-run the ci, maybe itll fix the flaky test 🤔

Rexicon226 avatar Nov 27 '23 13:11 Rexicon226

will merge the latest changes from master to re-run the ci, maybe itll fix the flaky test 🤔

Try

diff --git a/lib/std/net/test.zig b/lib/std/net/test.zig
index caac8f4e6..69f40aba9 100644
--- a/lib/std/net/test.zig
+++ b/lib/std/net/test.zig
@@ -356,6 +356,7 @@ test "non-blocking tcp server" {
     defer socket_file.close();
 
     var client = try server.accept();
+    defer client.stream.close();
     const stream = client.stream.writer();
     try stream.print("hello from server\n", .{});

matu3ba avatar Dec 12 '23 21:12 matu3ba

saw the discussion earlier about this 😃

the ci has already passed when i rebased so it wouldn't make much sense now, but i hope it helps in the future.

Rexicon226 avatar Dec 12 '23 23:12 Rexicon226

Needs a rebase and then another review from @mlugg

andrewrk avatar Jan 14 '24 23:01 andrewrk

Needs a rebase and then another review from @mlugg

Can do right now!

Rexicon226 avatar Jan 14 '24 23:01 Rexicon226

Nice work, thanks!

mlugg avatar Jan 20 '24 17:01 mlugg