zig icon indicating copy to clipboard operation
zig copied to clipboard

make CompileStep.addRPath preserve relative paths

Open yujiri8 opened this issue 2 years ago • 1 comments

Closes #15849.

yujiri8 avatar May 30 '23 10:05 yujiri8

:shrug: this PR's purpose was only to make CompileStep.adRPath consistent with the -rpath flag to build-exe. I have no idea what behavior is desirable here, but if relative paths are being interpreted relative to the wrong root, isn't that a separate issue?

ghost avatar Jun 14 '23 20:06 ghost

There is also an issue resolving $ORIGIN on linux, I presume that this is what should be used if one wants to use a path relative to the installation dir? And a similar issue (resolving @executable_path on Darwin) that was solved by @kubkon here: https://github.com/ziglang/zig/pull/15061

I don't know how this stuff should work.

hazeycode avatar Jul 10 '23 19:07 hazeycode

Alright. Well, I'm not going to do any more work on this. Others feel free to add commits or close.

ghost avatar Jul 10 '23 20:07 ghost

Alright. Well, I'm not going to do any more work on this. Others feel free to add commits or close.

I think what you have here is correct. But if it turns out to not be aligned with whatever the correct behavior is holistically, then I'd be happy to pick it up. I don't know what that is so hopefully someone else can clarify.

hazeycode avatar Jul 10 '23 21:07 hazeycode