rfc icon indicating copy to clipboard operation
rfc copied to clipboard

FileMQ (RFC 35) cheezburger.sequence

Open ojake opened this issue 5 years ago • 1 comments

In the grammar for the cheezburger command there are two fields: sequence and offset with the same exact explanation: "File offset in bytes". In a command description sequence isn't even mentioned.

Is the sequence field redundant or does it just lacks description? RFC 19 has the same problem.

Grammar:

; The server sends a file chunk cheezburger = signature %d8 sequence operation filename offset eof headers chunk sequence = number-8 ; File offset in bytes operation = number-1 ; Create=%d1 delete=%d2 filename = string ; Relative name of file offset = number-8 ; File offset in bytes eof = number-1 ; Last chunk in file? headers = dictionary ; File properties chunk = chunk ; Data chunk

Command description

The CHEEZBURGER Command The server SHALL send file content to the client using CHEEZBURGER commands. Each CHEEZBURGER command shall deliver a chunk of file data starting at a specific offset. The server MUST send the content of a single file as consecutive chunks and clients MAY depend on this behavior.

The headers field is reserved for future use.

ojake avatar Sep 22 '20 15:09 ojake

If I remember correctly sequence is the offset where to start reading and offset is how much to read from there.

ojake [email protected] schrieb am Di., 22. Sept. 2020, 17:28:

In the grammar for the cheezburger command there are two fields: sequence and offset with the same exact explanation: "File offset in bytes". In a command description sequence isn't even mentioned.

Is the sequence field redundant or does it just lacks description? RFC 19 has the same problem.

Grammar:

; The server sends a file chunk cheezburger = signature %d8 sequence operation filename offset eof headers chunk sequence = number-8 ; File offset in bytes operation = number-1 ; Create=%d1 delete=%d2 filename = string ; Relative name of file offset = number-8 ; File offset in bytes eof = number-1 ; Last chunk in file? headers = dictionary ; File properties chunk = chunk ; Data chunk

Command description

The CHEEZBURGER Command The server SHALL send file content to the client using CHEEZBURGER commands. Each CHEEZBURGER command shall deliver a chunk of file data starting at a specific offset. The server MUST send the content of a single file as consecutive chunks and clients MAY depend on this behavior.

The headers field is reserved for future use.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zeromq/rfc/issues/178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNOTIG3OZCKT2Q35WVVTSHC7A3ANCNFSM4RV5NPBA .

sappo avatar Sep 25 '20 06:09 sappo