php-zmq icon indicating copy to clipboard operation
php-zmq copied to clipboard

Zyre binding

Open wysman opened this issue 11 years ago • 7 comments

Add the class ZMQZyre which is a binding of the libzyre. Zyre is an open-source framework for proximity-based peer-to-peer applications. Zyre is based on ZMQ and supported by iMatix.

The ZMQZyre class is add to the php extension if all library dependency are validate, if not this part of the code is disable automatically to avoid build error.

  • libzyre == 1.x.x
  • czmq >= 2.2.0

wysman avatar Jul 03 '14 07:07 wysman

Hi,

looks good! Added a few inline comments.

mkoppanen avatar Jul 03 '14 07:07 mkoppanen

Hi, Thanks for your review, previous commits fix your remarks. I will add 1/2 methods to the class and some others tests ASAP

wysman avatar Jul 03 '14 09:07 wysman

@mkoppanen Well done, Mr travis is green. Can you review again the socket creating and delete, Thanks

https://github.com/wysman/php-zmq/blob/zyre/zmq.c#L1987 https://github.com/wysman/php-zmq/blob/zyre/zmq.c#L1617

wysman avatar Jul 03 '14 11:07 wysman

I just realize that "zend_throw_exception_ex" do not break the execution flow like C++ exception. Can you suggest a good book about php extension writing ?

wysman avatar Jul 16 '14 07:07 wysman

The only book I know is Sara Golemon's book and that's getting a bit dated.

mkoppanen avatar Jul 16 '14 09:07 mkoppanen

Abandoned?

mkoppanen avatar Jan 09 '16 01:01 mkoppanen

Hi,

I do not have work on this feature for a while, but it was left working and cover with tests units. Maybe we can upgrade the branch to support the last zyre release 7 days ago.

William

wysman avatar Jan 14 '16 08:01 wysman