phpkiteconnect icon indicating copy to clipboard operation
phpkiteconnect copied to clipboard
verified publisher icon zerodha

refactor: PHP 7.3 compatibility

Open pushpak1300 opened this issue 4 years ago • 5 comments

For PHP 7.3 backward compatibility which resolves #19 . Tested this on PHP7.3 locally and all tests are passing.

Screenshot from 2021-04-21 12-43-00

@vividvilla @ranjanrak

pushpak1300 avatar Apr 21 '21 07:04 pushpak1300

Thanks for the PR. I Will go through this over weekend and update here.

ranjanrak avatar Apr 23 '21 05:04 ranjanrak

Thanks for the PR. I Will go through this over weekend and update here.

Any updates?

pushpak1300 avatar May 10 '21 09:05 pushpak1300

@pushpak1300 We should also remove the Mixed_ Docblock type enforced in invalidateRefreshToken and modifyOrder functions, when mixed type is already added in docblock comment above these functions.

ranjanrak avatar May 14 '21 06:05 ranjanrak

@ranjanrak any updates?

pushpak1300 avatar Jul 04 '21 17:07 pushpak1300

LGTM. @vividvilla, you can merge this.

ranjanrak avatar Jul 05 '21 07:07 ranjanrak