zend-expressive-hal icon indicating copy to clipboard operation
zend-expressive-hal copied to clipboard

Exposed embedded key existence in HalResource, added a test to check …

Open jguittard opened this issue 7 years ago • 2 comments

Provide a narrative description of what you are trying to accomplish:

  • [x] Are you fixing a bug?
    • [x] Detail how the bug is invoked currently.
    • [x] Detail the original, incorrect behavior.
    • [x] Detail the new, expected behavior.
    • [x] Base your feature on the master branch, and submit against that branch.
    • [x] Add a regression test that demonstrates the bug, and proves the fix.
    • [ ] Add a CHANGELOG.md entry for the fix.

See https://github.com/zendframework/zend-expressive-hal/issues/52 for details

jguittard avatar Jan 08 '19 12:01 jguittard

This repository has been closed and moved to mezzio/mezzio-hal; a new issue has been opened at https://github.com/mezzio/mezzio-hal/issues/3.

weierophinney avatar Dec 31 '19 20:12 weierophinney

This repository has been moved to mezzio/mezzio-hal. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone mezzio/mezzio-hal to another directory.
  • Copy the files from the second bullet point to the clone of mezzio/mezzio-hal.
  • In your clone of mezzio/mezzio-hal, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 20:12 weierophinney