desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Some Cmd Shortcuts Don't Work Anymore (Cmd+Q Cmd+,)

Open Coops0 opened this issue 1 year ago • 43 comments

Captchas

  • [X] I have read the instructions.
  • [X] I have searched existing issues and avoided creating duplicates.
  • [X] I am not filing an enhancement request.

What happened?

On Mac (Sequoia), holding the Cmd key and pressing a number 1-9 usually takes you to that tab index. Now, it just does nothing. I am still able to ctrl+tab through them, and other cmd shortcuts like Cmd+T and Cmd+C still work.

Additional broken keybinds: Cmd+F, Cmd+,, Cmd+Q

Reproducible?

  • [X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.4

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

Coops0 avatar Sep 23 '24 13:09 Coops0

Other broken shortcuts:

  • Cmd+Shift+T (Restore tab)
  • Cmd+R (Reload)
  • Cmd+Shift+L (Bitwarden autofil trigger)
  • Cmd + A (Select All)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

stavros-k avatar Sep 23 '24 13:09 stavros-k

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

Can confirm all of this - it is very strange ctrl works for these...

Coops0 avatar Sep 23 '24 14:09 Coops0

Can confirm all of this - it is very strange ctrl works for these...

It's just the windows/linux shortcuts, which I assume are the defaults until a mac is identified or something.

stavros-k avatar Sep 23 '24 14:09 stavros-k

Also happening on macOS Sonoma 14.6.1

netzzwerk avatar Sep 23 '24 14:09 netzzwerk

Possibly caused by: https://github.com/zen-browser/desktop/commit/232fa448ca4177af0cf5d961e385ab2fd40785d1? Seems to pertain to keyboard shortcuts and is tagged as the latest release.

say4n avatar Sep 23 '24 14:09 say4n

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

* `Cmd` + `A` (Select All)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

for me Cmd+A, Cmd+T work, Cmd+R and Cmd+Shift+T don't.

AleksZakirov avatar Sep 23 '24 16:09 AleksZakirov

Same issue here, I'm on macOS Sequoia 15.0 (24A335)

I started to use Zen today, so IDK if I'm missing some other shortcuts, but at least these ones failed:

  • cmd+shift+t to restore last tab closed (is working with ctrl instead)
  • cmd+r
  • cmd+` (this is to use 1password autofill)

sebazelonka avatar Sep 23 '24 17:09 sebazelonka

Will fix this ASAp, releasing today.

mr-cheffy avatar Sep 23 '24 17:09 mr-cheffy

Apologies to everyone. We included a patch for macOS specifically adjusting functionality of the modifiers (supposedly fixing https://github.com/zen-browser/desktop/issues/1363) and it seems like it is interfering with the previous functionality. As @mauro-balades noted, we'll fix this with the new release.

HarryHeres avatar Sep 23 '24 17:09 HarryHeres

Other broken shortcuts:

* `Cmd`+`Shift`+`T` (Restore tab)

* `Cmd`+`R` (Reload)

* `Cmd`+`Shift`+`L` (Bitwarden autofil trigger)

* `Cmd` + `A` (Select All)

Note that the above works if I use the Ctrl instead of Cmd So something is funky there

For me, Cmd+R and Cmd+A are working. But would like to add Cmd+L to the list of non-working shortcuts.

bangoim avatar Sep 23 '24 19:09 bangoim

Unfortunately, after updating, the Cmd+<Number> keybind still doesn't work. Some others do seem to work though. Cmd+, (settings) doesn't seem to work either?

When on the settings tab, other shortcuts do not work now either?? e.x. Cmd+W Ctrl+<number> doesn't work either

EDIT: Cmd+F goes into fullscreen, not search/find

Coops0 avatar Sep 23 '24 23:09 Coops0

Hi! I don't know if I need to open a new issue but on the latest version 1.0.1-a.4 only the following commands work:

  • CMD + L
  • CMD + R
  • CMD + T
  • CMD + W
  • CMD + P
  • CMD + +
  • CMD + -
  • CMD + 0
  • CMD + A

The commands that DO NOT work are:

  • CMD + Number
  • CMD + ,
  • CMD + Q
  • CTRL + Number (worked on 1.0.1-a.3 when 'CMD + Number' didn't work)
  • Any user keyboard shortcut with CMD
  • Whenever you try to modify a keyboard shortcut: 'CTRL + OPTION + E' you get 'CTRL + OPTION + €' (this has been an issue since previous versions)

Valadramuz avatar Sep 23 '24 23:09 Valadramuz

Ctrl+W doesn't work anymore for me. It used to be able to before I restarted the browser. But even after restarting the browser again, CTRL + W works, but only once.

y2k04 avatar Sep 24 '24 04:09 y2k04

So after the update to 1.0.1-a.4, some of the CMD shortcuts work but some of the still don't, is that right?

HarryHeres avatar Sep 24 '24 05:09 HarryHeres

So after the update to 1.0.1-a.4, some of the CMD shortcuts work but some of the still don't, is that right?

Correct, 1.0.1-a4 has the behavior that @Valadramuz listed

josefssonemil avatar Sep 24 '24 06:09 josefssonemil

https://github.com/zen-browser/desktop/issues/1686

On linux:

CTRL + Shift + B (bookmarks bar toggle) does not work as well.

KarimElsayad247 avatar Sep 24 '24 11:09 KarimElsayad247

@HarryHeres I'm facing something similar with linux, with ctrl + shift + b not working. Could this be related to this max issue?

KarimElsayad247 avatar Sep 24 '24 11:09 KarimElsayad247

Would like to add that in the in the release notes is said that it was added a new system for handling keyboard shortcuts. The interface is the same, didn't see no difference and it is loaded with duplicates and swapped commands. Also, in MacOS the shortcuts that should be showing Cmd + something are showing as Ctrl + something.

Cmd + F: makes browser go full screen instead of searching inside the tab. Cmd + ,: does not go to settings. Cmd + Shift + B and Cmd + B: not working for bookmarks. Cmd + H: does not open history. Cmd + {number}: does not switch tabs. Cmd + Opt + U: sends to view-source:about:preferences#zenCKS instead of closing split view.

Those are the ones that most impacted me, there is possibly more.

Another thing is the missing labels on some shortcuts and duplicated ones.

image

bangoim avatar Sep 24 '24 12:09 bangoim

I can confirm that Alt + 1 through Alt + 9 don't work on linux.

KarimElsayad247 avatar Sep 24 '24 12:09 KarimElsayad247

Not sure if this should go here, but with version 1.0.1-a.4, I cannot open bookmarks or history using Ctrl + B or Ctrl + H.

I am on openSUSE Leap 15.5 and Zen Browser installed via a flatpak.

Update: applied version 1.0.1-a.5 and bookmarks now dock using Ctrl +B.

kgarrett67 avatar Sep 24 '24 13:09 kgarrett67

I'm on windows and my shortcuts are also all messed up, the open private window changed itself to "ctrl shift p" and the new tab one stopped working as of the latest update.

gk98s avatar Sep 24 '24 13:09 gk98s

To add: I have created multiple profiles before recent updates, and only the main (default) profile got affected. (macOS 14.7)

EDIT: 5 minutes after I post this, I receive a new update and things work now

fhfuih avatar Sep 25 '24 01:09 fhfuih

How do I update to the recent version? About Zen window doesn't have a way to check for a new version.

Edit: It could be because I installed using Flatpak. I'm now updating using flatpak update

Edit2: Shortcuts are now working for me :+1:

Thanks for the hard work everyone @mauro-balades @HarryHeres You're doing really great work :pray: :pray: :pray:

KarimElsayad247 avatar Sep 25 '24 07:09 KarimElsayad247

The option for setting a shortcut for "Next tab" and "Previous tab" is gone now - can we have these back?

Amplificator avatar Sep 27 '24 18:09 Amplificator

Cmd + , broke again in 1.0.1-a-6 :(

chlorine3545 avatar Sep 30 '24 07:09 chlorine3545

Cmd + , broke again in 1.0.1-a-6 :(

Unfortunately can confirm, I also notice Cmd + q is broken.

Coops0 avatar Sep 30 '24 12:09 Coops0

Cmd + , broke again in 1.0.1-a-6 :(

Cmd + h also not working.

bangoim avatar Sep 30 '24 15:09 bangoim

The problem is still bothering me in 1.0.1-a-7 :(

chlorine3545 avatar Oct 01 '24 00:10 chlorine3545

Seems like 1.0.1-a-5 was the last working version.

say4n avatar Oct 02 '24 14:10 say4n