numcodecs icon indicating copy to clipboard operation
numcodecs copied to clipboard

Add linux aarch64 wheel build support

Open odidev opened this issue 4 years ago • 6 comments

Add linux aarch64 wheel build support.

Related to https://github.com/zarr-developers/numcodecs/issues/288 @joshmoore Could you please review this PR?

odidev avatar Oct 06 '21 02:10 odidev

What is needed to include this pull request in the master branch? Aarch64 wheels for Linux are convenient.

jthetzel avatar Apr 12 '22 18:04 jthetzel

Apologies, @odidev. I have no idea how I missed this originally! Never hesitate to re-ping or jump on https://gitter.im/zarr-developers/community -- I'll take a look ASAP.

joshmoore avatar Apr 12 '22 18:04 joshmoore

Also looking at the conflict, @odidev and @jthetzel, any thoughts on the use of pypa/[email protected] from #309?

joshmoore avatar Apr 12 '22 18:04 joshmoore

Also looking at the conflict, @odidev and @jthetzel, any thoughts on the use of pypa/[email protected] from #309?

Testing that at https://github.com/zarr-developers/numcodecs/pull/315 . Please advise if not kosher. I get confused on best practices pull requesting against pull requests.

jthetzel avatar Apr 12 '22 19:04 jthetzel

@jthetzel: no worries. Git can take care of all of that. More important is the semantics of the explicit calls to cibuildwheel versus the pre-built action which I'm not familiar enough with to deciper ("without more effort"™️)

joshmoore avatar Apr 12 '22 19:04 joshmoore

Sorry for the lack of reply here. Thought I had already replied.

The main concern from my perspective is CI time is getting pretty long for the wheel builds ( https://github.com/zarr-developers/numcodecs/issues/312 ). Would like to limit the builds for custom architectures, libc implementations, etc.. Namely not running on every commit, but only running if a label is added, some text in the commit, particular files changed, etc. Something to keep the build time manageable.

jakirkham avatar May 04 '22 20:05 jakirkham

Edit: removed comment once I realized the discussion had moved to #315.

rabernat avatar Jan 24 '23 17:01 rabernat

Going to close in favor of PR ( https://github.com/zarr-developers/numcodecs/pull/315 ), which is more up-to-date. Hopefully this more cleanly organizes discussion around this change. Thanks for the work @odidev! 🙏

jakirkham avatar Jan 24 '23 23:01 jakirkham