handynotes-plugins icon indicating copy to clipboard operation
handynotes-plugins copied to clipboard

v44 shows incorrect rewards, reward types and completion (blue skull instead of white) for several rares in the Emerald Dream

Open hollo6 opened this issue 2 years ago • 11 comments

ADDON VERSION: v44

Describe the bug Some rares in the Emerald Dream show incorrect rewards or reward types on their tooltips or icon completion state. Didn't have time to take a screenshot of Mosa Umbramane, it was showing Owlbear's Decisive Strike being a Recipe on a Tailor/Enchanter character. See screenshots for other issues I've found.

Screenshots this item should be a Recipe and only shown for Scribes (my character is not one), and it doesn't drop from this rare: image still blue even though all rewards are known (works correctly in v43): image

hollo6 avatar Nov 11 '23 16:11 hollo6

Found two more, these already exist in v43: image image

hollo6 avatar Nov 11 '23 16:11 hollo6

Which class do you play? Are all screenshots from your Tailor/Enchanter character ?

Dathwada avatar Nov 11 '23 17:11 Dathwada

First 2 screenshots (Bloodstripe Great Ray, Splinterlimb) are from Druid (Herb/Alchemy), the others from Warlock (Tailor/Enchanter). But I have every class and every profession I can test with if that helps.

hollo6 avatar Nov 11 '23 17:11 hollo6

Please try to disable and re-enable the rares and see if this fixes the rares are still blue for now. ss+(2023-11-11+at+06 32 20)

  • Fixed Mosa Umbramane loot.
  • Bloodstripe Great Ray drops no recipe (see wowhead)
    • I'll also remove Hairy Chin

Screenshots from my druid with alchemy and enchanting

Dathwada avatar Nov 11 '23 17:11 Dathwada

I just updated back to v44 to test if re-enabling the rares fixes this issue but it seems to work after login/reload. I have noticed this on both characters after some time of normal gameplay, so there must be some trigger for this behavior.

hollo6 avatar Nov 11 '23 18:11 hollo6

Now the still blue problem happened after logging in and doing nothing special. Re-enabling rares fixed it but only temporarily.

hollo6 avatar Nov 12 '23 03:11 hollo6

It looks like only rares that have recipes as a reward are affected.

Dathwada avatar Nov 12 '23 14:11 Dathwada

@Dathwada can you try to add

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

Ioney avatar Nov 14 '23 00:11 Ioney

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

I don't think that would help because the affected characters have that profession and learned those recipes.

hollo6 avatar Nov 14 '23 07:11 hollo6

@Dathwada can you try to add

function Recipe:IsObtainable() return ns.PlayerHasProfession(self.profession) end

to line 450 in core/rewards.lua

maybe this helps?

Doesn't work.

The issue is that Recipe:IsObtained() returns false at login.

Dathwada avatar Nov 14 '23 13:11 Dathwada

I checked this on the TWW beta and it looks like this is fixed and we can determine at login if a recipe is obtained.

Dathwada avatar Jul 09 '24 14:07 Dathwada

Closing as this hasn't had any activity in almost a year.

zarillion avatar Sep 15 '24 03:09 zarillion