lab icon indicating copy to clipboard operation
lab copied to clipboard

commentChar=auto not supported

Open zaquestion opened this issue 8 years ago • 4 comments

https://github.com/github/hub/issues/1512 is definitely also an issue in lab.

zaquestion avatar Sep 07 '17 08:09 zaquestion

the issue has been resolved in hub, check out the changeset here: https://github.com/github/hub/pull/1660

mareksuscak avatar Jan 23 '18 17:01 mareksuscak

Considering the way lab works today, I'm kinda skeptical it's still a problem for us. @zaquestion any thoughts? I'm inclined to close it.

bmeneg avatar Jun 15 '21 13:06 bmeneg

I wouldn't be surprised if this is still an issue. That said I think the bigger/more important update to make is https://github.com/zaquestion/lab/issues/334

zaquestion avatar Jul 21 '21 21:07 zaquestion

Hi, I have come across this issues as I am using commentChar=; and have noticed that it adversely affects writing notes. lab issue 123 note opens an editor with the following content:

                                                                  
# This comment is being applied to OPEN Issue 1040.               
; Write a message for this note. Commented lines are discarded.

This is because https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L182 uses commentChar, while https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L114 and https://github.com/zaquestion/lab/blob/master/cmd/note_common.go#L126 use #

The result is that I have to delete one of the lines in the editor, if my commentChar is not set to #, or that line will appear in the comment. If commentChar=auto I suspect I'd have to delete both lines, although I haven't tested that to confirm it.

simonbrent avatar Jul 27 '21 15:07 simonbrent