react-ionicons icon indicating copy to clipboard operation
react-ionicons copied to clipboard

Including a . in the migration script regex

Open travissouthard opened this issue 4 years ago • 0 comments

I ran the migration script last week and ran into a bit of trouble with the import statements. Instead of changing the import lines to * from "react-ionicons" it skipped over the . at the end of the line and the from became react-ionicons.js

I locally changed line 25 in the migration file to include a . in the regex and that worked the second time. Example: line = line.replace(/(react-ionicons\/lib\/[a-zA-Z]*)/, 'react-ionicons') became: line = line.replace(/(react-ionicons\/lib\/[a-zA-Z.]*)/, 'react-ionicons')

And that solved the problem for us and helped the import lines match what's recommended in the documentation.

travissouthard avatar Apr 26 '21 13:04 travissouthard