wkhtmltopdf_binary_gem icon indicating copy to clipboard operation
wkhtmltopdf_binary_gem copied to clipboard

Add support to ubuntu 22.04 and 24.04 in arm64

Open chileung-b4b opened this issue 1 year ago • 3 comments

The binary is the same for Ubuntu 22.04 and 24.04

[!IMPORTANT] To check the binary is the same as the one from https://wkhtmltopdf.org/downloads.html before using and/or merging this branch, run the following:

$ curl -L https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6.1-2/wkhtmltox_0.12.6.1-2.jammy_arm64.deb > wkhtmltox_0.12.6.1-2.jammy_arm64.deb
$ dpkg -x wkhtmltox_0.12.6.1-2.jammy_arm64.deb wkhtmltox/
$ git clone -b add-ubuntu-24-04-arm --single-branch --depth 1 https://github.com/chileung-b4b/wkhtmltopdf_binary_gem.git
$ gunzip -c ./wkhtmltopdf_binary_gem/bin/wkhtmltopdf_ubuntu_22.04_arm64.gz | sha256sum -
00fbba5e1ee392776c2978b45503c07af34c42086c842b31dc9d7a76d52fcf29  -
$ sha256sum wkhtmltox/usr/local/bin/wkhtmltopdf
00fbba5e1ee392776c2978b45503c07af34c42086c842b31dc9d7a76d52fcf29  wkhtmltox/usr/local/bin/wkhtmltopdf

chileung-b4b avatar Sep 10 '24 22:09 chileung-b4b

Thank you @chileung-b4b. I just used your addition on my Ubuntu 22.04 ARM installation and it worked great. I hope to see this merged in.

ksamc avatar Sep 16 '24 23:09 ksamc

Thank you @chileung-b4b! I was about to work in this direction, but your changes are working like a charm while testing some CI stuff on GitHub Actions with ARM.

g3ortega avatar Sep 21 '24 23:09 g3ortega

Updated description with instructions to check the added binary's hash

chileung-b4b avatar Sep 23 '24 08:09 chileung-b4b

@unixmonkey Any chance we could get this merged? Trying to run the latest version on ARM which is causing this error for Ubuntu ...

Invalid platform, must be running on Ubuntu 16.04/18.04/20.04/22.04, CentOS 6/7/8, Debian 9/10/11/12, Archlinux amd64, Debian 9/10/11/12 arm64, or Intel-based Cocoa macOS (missing binary: /srv/bundle/ruby/3.3.0/gems/wkhtmltopdf-binary-0.12.6.8/bin/wkhtmltopdf_ubuntu_22.04_arm64). (RuntimeError)

itskingori avatar Jan 09 '25 19:01 itskingori

@zakird Pinging you as well, in case you're in a position to assist.

itskingori avatar Jan 10 '25 06:01 itskingori

Hi, following up on this, could we have this PR merged at your earliest availability please? 🙏🏾

jt-shippit avatar Feb 20 '25 21:02 jt-shippit

@unixmonkey @zakird Are you able to merge the PR, please? If you require any additional changes, can you leave them in this thread?

joshgaber avatar Mar 18 '25 15:03 joshgaber

Sorry it took awhile, but this is now released in version 0.12.6.9. Thank you so much!

unixmonkey avatar May 16 '25 14:05 unixmonkey