allocator-api2 icon indicating copy to clipboard operation
allocator-api2 copied to clipboard

TryReserveError is not re-exported

Open CeleritasCelery opened this issue 1 year ago • 2 comments

The version of TryReserveError from allocator_api2 is not publicly re-exported, so it cannot be named in types. Unless there is a specific reason for this, it seems like it should be exported to make it at least as useful as the std-lib version.

Also the docs for try_reserve still reference the one in std::collections.

CeleritasCelery avatar Apr 03 '24 20:04 CeleritasCelery

Should've been fixed in a16a359038cf741aa6445809e33a845e17e58c0d

zakarumych avatar Aug 16 '24 20:08 zakarumych

~It looks like the fix introduced by https://github.com/zakarumych/allocator-api2/commit/a16a359038cf741aa6445809e33a845e17e58c0d no longer appears in stable/mod.rs.~

~In other words, the bug is still there and the Vec::try_reserve API can't be compiled without nightly.~

It looks like the latest released crate version doesn't have this patch somehow, but the latest code in the main branch does.

amunra avatar Sep 23 '24 10:09 amunra