node-odata icon indicating copy to clipboard operation
node-odata copied to clipboard

Makefile breaks on Windows

Open andrerpena opened this issue 9 years ago • 1 comments

Hi. First, thanks for this project. I have interest in it and I would eventually contribute.

My problem is that you're using MAKE which doesn't work on Windows (at least not on my installation). I have never used a Makefile before but from where I'm standing, you're just using it to perform operations Node.js people would do in a Node.js way :smile: And this is preventing me from compiling it.

Can I remove the Makefile file and create corresponding package.json scripts? I mean, would you accept a PR?

Thank you.

andrerpena avatar Sep 01 '16 21:09 andrerpena

You are absolute correct. I choose Makefile to build this project because Makefile is easier maintain than npm script. Makefile has a little trouble running on windows, you have to install some tools for use MAKE command.

You can write it in package.json if you want, I will merge and appreciate it.

zackyang000 avatar Sep 02 '16 04:09 zackyang000