vscode-markdown-editor icon indicating copy to clipboard operation
vscode-markdown-editor copied to clipboard

Suggestion on default font size ; playing nice with dark theme

Open orionlee opened this issue 4 years ago • 2 comments

Two separate UI issues, but potential fixes are loosely related so I group them together.

  1. The default font size seems to be a bit too large.
  2. When Visual Studio Code is in a dark theme, the font color is not switched to light color.

image

For font size, it could be helpful if it can be specified by users. Another option is to obey Visual Studio Code's default size.


Suggested solution:

One way is to tweak the css:

https://github.com/zaaack/vscode-markdown-editor/blob/aefdc13c94b58fbc61ee9c860bf78110ca7447e1/media-src/src/main.css#L18-L21

If we add the following to the css rule, it'll make the editor area use vscode' default color / font size (rather than the hardcode value in .vditor style)

    font-size: var(--vscode-font-size, var(--theme-font-size));
    color: var(--vscode-editor-foreground, var(--theme-foreground));    

With the css change, it looks like:

image

orionlee avatar Jul 02 '21 04:07 orionlee

Yeah the font is quite large for me - macos

jamesoflol avatar Nov 14 '21 22:11 jamesoflol

大佬 快点改了发个版本呀 @zaaack

maolike avatar Jan 12 '22 08:01 maolike