Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Consider using serveStatic base implementation

@exoego Thank you for sharing your opinion! I can understand it well. We/I have some reasons and the historical stuff. I'll explain later.

Consider using serveStatic base implementation

@exoego Added the issue related to this discussion https://github.com/honojs/hono/issues/3483 Please take a look at it!

HTTP HEAD responses are missing content-length header

Hi @StuartMoncrieff Thank you for the issue. This should be resolved. @usualoma We can calculate and add a content length for the response to the `HEAD` request like the following,...

HTTP HEAD responses are missing content-length header

Hi @usualoma . Thank you for the idea. `buildResponse` looks good, but although the overhead seems slight, it is significant for Hono. This is because it takes a short time...

fix(hono/context): content-type be overridden by default response when append headers

Hi @xx1124961758 Thank you for the PR. I've left the comments. @sushichan044 Do you think this PR will fix #3736? If so, please review this. You may know the PR...

fix(hono/context): content-type be overridden by default response when append headers

The #4100 was merged. This can be closed. Thank you!

Using hono-node with the cors middleware causes a memory leak

@omarkhatibco I'll work on investigating it. One question, are you running your app on Node.js? or other runtime?

Using hono-node with the cors middleware causes a memory leak

@omarkhatibco > it starts to happens yesterday when I merged my PR which includes latest version of Hono v4.8.12 Does this mean the previous version you used did not cause...

Using hono-node with the cors middleware causes a memory leak

@krzkz94 Okay, thanks!

Using hono-node with the cors middleware causes a memory leak

@krzkz94 What version of `@hono/node-server` do you use?